[Renderers/Terminal] Feature/terminal renderer #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would keep the ncurses renderer separate from the ANSI escape code based one. |
EmmanuelMess
reviewed
Jan 6, 2025
| } | ||
|
|
||
|
|
||
| //written by EmmanuelMess: https://github.com/nicbarker/clay/pull/91/commits/7ce74ba46c01f32e4517032e9da76bf54ecf7a43 |
There was a problem hiding this comment.
Its probably not a good idea to add the author of the functions, git blame already provides this feature.
There was a problem hiding this comment.
It would, but I didn't use your branch, so it will show that I was the author instead. I want to make sure you get whatever credit you want for that.
nicbarker
changed the title
nicbarker
force-pushed
the
main
branch
2 times, most recently
from
4fd677e to
338852b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the work of @EmmanuelMess 7ce74ba
See the readme for more info, but this pull-request is for a terminal only renderer which utilizes ncurses which is found on nearly every linux distribution already